Bug 226252

Summary: Use `NSLocale` SPI for comparing language identifiers instead of string comparison
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, hi, jer.noble, mmaxfield, philipj, sergio, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226038
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Devin Rousso
Reported 2021-05-25 17:22:08 PDT
.
Attachments
Patch (6.21 KB, patch)
2021-05-25 17:27 PDT, Devin Rousso 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.91 KB, patch)
2021-05-26 20:17 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (6.51 KB, patch)
2021-05-26 20:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-05-25 17:27:30 PDT
Created attachment 429715 [details] Patch
Alexey Proskuryakov
Comment 2 2021-05-25 18:18:03 PDT
Comment on attachment 429715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429715&action=review > Source/WTF/ChangeLog:4 > + Use `NSLocale` SPI for comparing language identifiers instead of string comparison > + https://bugs.webkit.org/show_bug.cgi?id=226252 A "why" comment would be very useful here.
Devin Rousso
Comment 3 2021-05-26 20:17:13 PDT
Created attachment 429834 [details] Patch
Devin Rousso
Comment 4 2021-05-26 20:40:52 PDT
Created attachment 429837 [details] Patch
EWS
Comment 5 2021-05-27 10:54:22 PDT
Committed r278168 (238212@main): <https://commits.webkit.org/238212@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429837 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-27 10:55:19 PDT
<rdar://problem/78576565>
Note You need to log in before you can comment on or make changes to this bug.