Bug 225887

Summary: Clean up code distinguishing between webgl/webgl2 contexts
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 222758    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Kenneth Russell
Reported 2021-05-17 14:26:50 PDT
Per review on Bug 222758 - the code recently added to properly distinguish between WebGL 1.0 and 2.0 contexts should be cleaned up.
Attachments
Patch (2.45 KB, patch)
2021-05-17 14:29 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2021-05-18 09:33 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2021-05-17 14:29:31 PDT
Created attachment 428870 [details] Patch
Kenneth Russell
Comment 2 2021-05-17 20:23:52 PDT
FYI, the test failures/flakes are not related to this patch.
Darin Adler
Comment 3 2021-05-17 23:05:36 PDT
Comment on attachment 428870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428870&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:263 > + if ((version == WebGLVersion::WebGL1) != (m_context->isWebGL1())) Extra set of parentheses here that you did not add below.
Kenneth Russell
Comment 4 2021-05-18 09:33:47 PDT
Created attachment 428948 [details] Patch
Kenneth Russell
Comment 5 2021-05-18 09:34:09 PDT
Thanks for your review Darin. Fixed, CQ'ing.
EWS
Comment 6 2021-05-18 10:32:30 PDT
Committed r277659 (237864@main): <https://commits.webkit.org/237864@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428948 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-18 10:33:20 PDT
<rdar://problem/78162049>
Note You need to log in before you can comment on or make changes to this bug.