Bug 225644

Created attachment 428257 [details] Patch

Created attachment 428258 [details] Patch

Committed r277319 (237578@main): <https://commits.webkit.org/237578@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428258 [details].

<rdar://problem/77835076>

Re-opened since this is blocked by bug 225680

Once this patch landed the following tests started to fail: compositing/geometry/limit-layer-bounds-transformed-overflow.html [ Failure ] compositing/layer-creation/overflow-scroll-overlap.html [ Failure ] compositing/layer-creation/scroll-partial-update.html [ Failure ] compositing/overflow/content-gains-scrollbars.html [ Failure ] compositing/overflow/overflow-scrollbar-layer-positions.html [ Failure ] compositing/overflow/overflow-scrollbar-layers.html [ Failure ] css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html [ ImageOnlyFailure ] css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html [ ImageOnlyFailure ] fast/events/wheel/continuous-platform-wheelevent-in-scrolling-div.html [ Failure ] fast/forms/basic-textareas.html [ Failure ] fast/overflow/scrollRevealButton.html [ Failure ] fast/repaint/horizontal-bt-overflow-child.html [ Failure ] fast/repaint/horizontal-bt-overflow-parent.html [ Failure ] fast/repaint/horizontal-bt-overflow-same.html [ Failure ] fast/repaint/vertical-overflow-child.html [ Failure ] fast/repaint/vertical-overflow-parent.html [ Failure ] fast/repaint/vertical-overflow-same.html [ Failure ] fast/scrolling/overflow-scrollable-after-back.html [ Timeout ] fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html [ ImageOnlyFailure ] fast/scrolling/rtl-scrollbars-overflow-padding.html [ ImageOnlyFailure ] fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html [ ImageOnlyFailure ] fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html [ ImageOnlyFailure ] fast/spatial-navigation/snav-clipped-overflowed-content.html [ Failure ] fast/spatial-navigation/snav-only-clipped-overflow-content.html [ Failure ] fast/spatial-navigation/snav-simple-content-overflow.html [ Failure ] fast/text/mark-matches-overflow-clip.html [ Failure ] imported/blink/compositing/animation/hidden-animated-layer-should-not-have-scrollbars.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-flexbox/overflow-auto-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-overflow/scrollbar-empty-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-position/hypothetical-box-scroll-parent.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-ui/outline-negative-offset-composited-scroll.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-overflow.html [ ImageOnlyFailure ] scrollbars/corner-resizer-window-inactive.html [ ImageOnlyFailure ] scrollbars/scroll-rtl-or-bt-layer.html [ Failure ] svg/custom/invisible-text-after-scrolling.xhtml [ Failure ] It's 37 tests in total. With these many failures the EWS GTK-WK2 bots that we're currently testing in UAT will always fail, so I reverted the patch. Regarding how to fix this test, I initially thought that enabling AsyncOverflowScrolling, as WPE's WKRT does, was the right solution. Maybe that's still right but I'd need to examine with more detail the test results with this patch applied (I didn't pay attention to how many new passes there are, so perhaps that will compensate the new failures). Another alternative solution might be to enable AysncOverflowScrolling only for certain tests.

Created attachment 435075 [details] Patch

Committed r280743 (240329@main): <https://commits.webkit.org/240329@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435075 [details].