Bug 224563

Summary: Store whether a test is slow on TestInput
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161626
Attachments:
Description Flags
Patch
none
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-04-14 11:12:45 PDT
Bug 161626 introduced test-objects.json, however no test-objects.json files were ever added and this has thus been permanently dead code. Given it's lack of usage, let's remove it. Additionally, with it gone, the expectations is once against the canonical source of knowledge about whether a test is slow and we don't need to communicate this through all the various components.
Attachments
Patch (17.52 KB, patch)
2021-04-14 11:32 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Patch (34.03 KB, patch)
2021-05-19 16:18 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-04-14 11:32:10 PDT
Created attachment 426022 [details] Patch
Sam Sneddon [:gsnedders]
Comment 2 2021-04-15 07:22:35 PDT
Somehow I totally missed the file (did I look in Tools or something equally silly?), and this is in fact used. Hmm. I wonder what to do here instead; having two different places where we store this metadata (especially within webkitpy's data model) is somewhat clumsy and annoying.
Jonathan Bedard
Comment 3 2021-04-15 08:52:15 PDT
(In reply to Sam Sneddon [:gsnedders] from comment #2) > Somehow I totally missed the file (did I look in Tools or something equally > silly?), and this is in fact used. Hmm. I wonder what to do here instead; > having two different places where we store this metadata (especially within > webkitpy's data model) is somewhat clumsy and annoying. Seems like all the effected tests are http tests....is there any reason we can't convert them to normal test expectations?
Radar WebKit Bug Importer
Comment 4 2021-04-21 11:13:14 PDT
<rdar://problem/76969468>
Sam Sneddon [:gsnedders]
Comment 5 2021-05-19 16:18:08 PDT
Created attachment 429110 [details] Patch
Sam Sneddon [:gsnedders]
Comment 6 2021-05-19 16:21:10 PDT
(In reply to Jonathan Bedard from comment #3) > (In reply to Sam Sneddon [:gsnedders] from comment #2) > > Somehow I totally missed the file (did I look in Tools or something equally > > silly?), and this is in fact used. Hmm. I wonder what to do here instead; > > having two different places where we store this metadata (especially within > > webkitpy's data model) is somewhat clumsy and annoying. > > Seems like all the effected tests are http tests....is there any reason we > can't convert them to normal test expectations? We could, though there was concern about bloating TestExpectations with WPT before. I think some of this is also related to the fact they'd need to be marked as slow in _every_ TestExpectations file, unless I'm misremembering how platform-specific expectations are added. That said, this new patch does a bunch of refactoring that we need to do anyway, and with that done it becomes pretty easy to support tests-options.json again.
EWS
Comment 7 2021-05-20 06:48:50 PDT
Committed r277781 (237942@main): <https://commits.webkit.org/237942@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429110 [details].
Note You need to log in before you can comment on or make changes to this bug.