Bug 224265

Summary: [METAL ANGLE] Interface block declerations need to have children marked as struct accesses. Add implicit backing textures for multisample render targets
Product: WebKit Reporter: John Cunningham <johncunningham>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

John Cunningham
Reported 2021-04-06 20:54:05 PDT
[METAL ANGLE] Interface block declerations need to have children marked as struct accesses. Add implicit backing textures for multisample render targets
Attachments
Patch (4.29 KB, patch)
2021-04-06 20:57 PDT, John Cunningham 		no flags
DetailsFormatted DiffDiff
Patch (4.29 KB, patch)
2021-04-06 22:02 PDT, John Cunningham 		no flags
DetailsFormatted DiffDiff
Patch (7.08 KB, patch)
2021-04-06 22:29 PDT, John Cunningham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Cunningham
Comment 1 2021-04-06 20:57:32 PDT
Created attachment 425350 [details] Patch
EWS Watchlist
Comment 2 2021-04-06 20:58:29 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
John Cunningham
Comment 3 2021-04-06 21:01:15 PDT
Eventually this logic could be smarter. We may not always need to resolve and store the multisample texture, and the same for loading.
John Cunningham
Comment 4 2021-04-06 21:01:24 PDT
Eventually this logic could be smarter. We may not always need to resolve and store the multisample texture, and the same for loading.
John Cunningham
Comment 5 2021-04-06 22:02:36 PDT
Created attachment 425353 [details] Patch
John Cunningham
Comment 6 2021-04-06 22:29:01 PDT
Created attachment 425356 [details] Patch
EWS
Comment 7 2021-04-07 12:00:37 PDT
Committed r275617: <https://commits.webkit.org/r275617> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425356 [details].
Radar WebKit Bug Importer
Comment 8 2021-04-07 12:02:35 PDT
<rdar://problem/76359030>
Kyle Piddington
Comment 9 2021-04-07 12:15:21 PDT
*** Bug 223922 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.