Bug 223934

Summary:

Switch WebGL test suites from 1.0.3, 2.0.0 to 1.0.x, 2.0.y

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

ASSIGNED

Severity:

Normal

CC:

amir_mark, dino, gman, kbr, kkinnunen, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

214392, 222964, 214393

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch for EWS	none
Patch for EWS	none
Patch for EWS	none
Patch for EWS	none
For EWS	none
For EWS	ews-feeder: commit-queue-

Kimmo Kinnunen

Reported 2021-03-30 09:02:50 PDT

Switch WebGL test suites from 1.0.3, 2.0.0 to 1.0.x, 2.0.y

Attachments
Patch (92.68 KB, patch) 2021-03-30 09:17 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (124.48 KB, patch) 2021-09-03 04:44 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (127.52 KB, patch) 2021-09-06 03:34 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (129.53 KB, patch) 2021-09-07 06:22 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for EWS (133.83 KB, patch) 2022-03-03 03:42 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for EWS (145.36 KB, patch) 2022-03-03 05:09 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for EWS (145.70 KB, patch) 2022-03-04 04:21 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for EWS (145.99 KB, patch) 2022-03-07 00:29 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
For EWS (146.26 KB, patch) 2022-03-07 23:53 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
For EWS (146.68 KB, patch) 2022-03-08 05:27 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Kimmo Kinnunen

Comment 1 2021-03-30 09:17:12 PDT

Created attachment 424648 [details] Patch

Radar WebKit Bug Importer

Comment 2 2021-04-06 09:03:22 PDT

<rdar://problem/76269126>

Kimmo Kinnunen

Comment 3 2021-09-03 04:44:57 PDT

Created attachment 437261 [details] Patch

Kimmo Kinnunen

Comment 4 2021-09-06 03:34:30 PDT

Created attachment 437401 [details] Patch

Kimmo Kinnunen

Comment 5 2021-09-07 06:22:21 PDT

Created attachment 437494 [details] Patch

Kenneth Russell

Comment 6 2021-09-07 09:29:06 PDT

Comment on attachment 437494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437494&action=review Good work with this difficult test suite upgrade. Overall it looks good; a couple of small comments about some tests marked flaky and a block of preexisting suppressions. r+ > LayoutTests/TestExpectations:3701 > +webkit.org/b/229941 webgl/2.0.y/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Pass Failure ] Unfortunate that the s3tc-srgb test's failing on some configurations, but it's good it's tracked. > LayoutTests/platform/mac-wk2/TestExpectations:329 > +[ Monterey+ ] webgl/2.0.y/conformance/textures/video/tex-2d-rgba-rgba-unsigned_byte.html [ Skip ] These video-related tests have been skipped for a while on Monterey? This is concerning - they used to pass, and the tex-2d-rgba-rgba-unsigned-byte path is core to many video related WebGL applications. Possible to follow on with a bug for this? > LayoutTests/platform/mac-wk2/TestExpectations:332 > +[ Monterey+ ] webgl/2.0.y/conformance2/textures/image_bitmap_from_video/tex-2d-r11f_g11f_b10f-rgb-float.html [ Skip ] I'm pretty sure all of these image_bitmap related tests used to pass earlier in the WebGL 2.0 development cycle. Possible to investigate why they're failing now?

Kimmo Kinnunen

Comment 7 2021-09-08 11:56:49 PDT

(In reply to Kenneth Russell from comment #6) > Good work with this difficult test suite upgrade. Overall it looks good; a > couple of small comments about some tests marked flaky and a block of > preexisting suppressions. r+ Thanks for looking! > > LayoutTests/TestExpectations:3701 > > +webkit.org/b/229941 webgl/2.0.y/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Pass Failure ] > > Unfortunate that the s3tc-srgb test's failing on some configurations, but > it's good it's tracked. I think it's about Metal backend leaving textures uninitialised in general... If this is the case, probably some other tests suffer from this, too. > These video-related tests have been skipped for a while on Monterey? This is > concerning - they used to pass, and the tex-2d-rgba-rgba-unsigned-byte path > is core to many video related WebGL applications. Possible to follow on with > a bug for this? > > I'm pretty sure all of these image_bitmap related tests used to pass earlier > in the WebGL 2.0 development cycle. Possible to investigate why they're > failing now? Yeah, this should be solved but it's a bit complicated. There are few interacting internal platform reasons. We can use for example bug 229837 to track these.

Kenneth Russell

Comment 8 2021-09-08 15:01:51 PDT

(In reply to Kimmo Kinnunen from comment #7) > (In reply to Kenneth Russell from comment #6) > > Good work with this difficult test suite upgrade. Overall it looks good; a > > couple of small comments about some tests marked flaky and a block of > > preexisting suppressions. r+ > > Thanks for looking! > > > > LayoutTests/TestExpectations:3701 > > > +webkit.org/b/229941 webgl/2.0.y/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Pass Failure ] > > > > Unfortunate that the s3tc-srgb test's failing on some configurations, but > > it's good it's tracked. > > I think it's about Metal backend leaving textures uninitialised in general... > If this is the case, probably some other tests suffer from this, too. That would be concerning. Started a thread on the Slack instance about that possibility. We should try to confirm this ASAP.

Brent Fulgham

Comment 9 2022-02-12 20:44:21 PST

*** Bug 223586 has been marked as a duplicate of this bug. ***

Kimmo Kinnunen

Comment 10 2022-03-03 03:42:47 PST

Created attachment 453717 [details] Patch for EWS

Kimmo Kinnunen

Comment 11 2022-03-03 05:09:44 PST

Created attachment 453723 [details] Patch for EWS

Kimmo Kinnunen

Comment 12 2022-03-04 04:21:02 PST

Created attachment 453832 [details] Patch for EWS