Bug 223888

Summary: [GStreamer] Test harness should use a mock audio output device
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, ews-watchlist, glenn, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224053    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2021-03-29 11:32:37 PDT
Since ~ 2012 we have a script called "pulseaudio_sanitizer" which unloads/loads some restore-stream module. This is not working at all with pipewire-pulse. Besides, having to bear with beeps and boops when running tests on a desktop machine is a bit annoying. Proposal: Use a fakeaudiosink element, up-ranked when running the test harness, so that it is picked up by autoaudiosink.
Attachments
Patch (15.01 KB, patch)
2021-04-01 09:58 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-04-01 09:58:49 PDT
Created attachment 424910 [details] Patch
Adrian Perez
Comment 2 2021-04-01 11:44:41 PDT
Comment on attachment 424910 [details] Patch Good one, and nice to see some code go the way of the dodo, too =)
EWS
Comment 3 2021-04-06 06:38:20 PDT
Committed r275513: <https://commits.webkit.org/r275513> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424910 [details].
Note You need to log in before you can comment on or make changes to this bug.