Bug 223523

Summary:

[GPUP] Add a "wallTime" field to struct RemoteMediaPlayerState

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

New Bugs

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, jonlee, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=221693

Bug Depends on:

Bug Blocks:

221693

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Fix test failures and update TestExpectations	eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing	none
Patch for landing - v2	none

Peng Liu

Reported 2021-03-19 10:23:47 PDT

Add a “timestamp” field to struct RemoteMediaPlayerState

Attachments
Patch (13.71 KB, patch) 2021-03-19 11:39 PDT, Peng Liu	no flags	Details Formatted Diff Diff
Patch (13.70 KB, patch) 2021-03-19 11:42 PDT, Peng Liu	ews-feeder: commit-queue-	Details Formatted Diff Diff
Fix test failures and update TestExpectations (13.19 KB, patch) 2021-03-19 14:07 PDT, Peng Liu	eric.carlson: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (15.84 KB, patch) 2021-03-19 23:55 PDT, Peng Liu	no flags	Details Formatted Diff Diff
Patch for landing - v2 (15.90 KB, patch) 2021-03-20 00:39 PDT, Peng Liu	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Peng Liu

Comment 1 2021-03-19 11:39:48 PDT

Created attachment 423755 [details] Patch

Peng Liu

Comment 2 2021-03-19 11:42:17 PDT

Created attachment 423756 [details] Patch

Peng Liu

Comment 3 2021-03-19 14:07:32 PDT

Created attachment 423774 [details] Fix test failures and update TestExpectations

Eric Carlson

Comment 4 2021-03-19 14:50:06 PDT

Comment on attachment 423774 [details] Fix test failures and update TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814 > + m_cachedState.timestamp = WallTime::now(); Nit: I think 'wallTime' might be more clear than 'timestamp'

Peng Liu

Comment 5 2021-03-19 14:54:45 PDT

Comment on attachment 423774 [details] Fix test failures and update TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review >> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814 >> + m_cachedState.timestamp = WallTime::now(); > > Nit: I think 'wallTime' might be more clear than 'timestamp' Good idea! Will fix it after getting results from bots.

Peng Liu

Comment 6 2021-03-19 23:55:26 PDT

Created attachment 423805 [details] Patch for landing Revise the patch based on Eric's comment and fix a layout test failure in the previous version.

Peng Liu

Comment 7 2021-03-20 00:39:22 PDT

Created attachment 423806 [details] Patch for landing - v2

EWS

Comment 8 2021-03-22 16:26:28 PDT

Committed r274816: <https://commits.webkit.org/r274816> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423806 [details].

Radar WebKit Bug Importer

Comment 9 2021-03-22 16:27:36 PDT

<rdar://problem/75714239>

Note You need to log in before you can comment on or make changes to this bug.