Bug 223260

Summary: ANGLE Metal fixups for program generation, readPixels
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 222239    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kyle Piddington
Reported 2021-03-16 10:17:03 PDT
ANGLE Metal fixups for program generation
Attachments
Patch (6.26 KB, patch)
2021-03-16 10:44 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2021-03-17 10:43 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (9.46 KB, patch)
2021-03-17 10:50 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-03-16 10:44:16 PDT
Created attachment 423353 [details] Patch
EWS Watchlist
Comment 2 2021-03-16 10:45:20 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kyle Piddington
Comment 3 2021-03-16 10:48:57 PDT
2021-03-16 Kyle Piddington <kpiddington@apple.com> ANGLE Metal fixups for program generation, readPixels https://bugs.webkit.org/show_bug.cgi?id=223260 This diff fixes the following tests: webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate.html Is fixed by dropping 'thread' qualifiers on our intermediate texture sampling helper functions. Previously, any uniforms used in sampling textures would have had issues with their namespace. webgl/2.0.0/conformance2/reading/read-pixels-pack-parameters.html is fixed by correcting an issue with reading from outside the framebuffer. ANGLE Metal was previously reading to the start of the output array, rather than a proper offset. webgl/2.0.0/conformance2/glsl3/array-equality.html is fixed by adding additional equality functions for handling arrays of structs. Reviewed by NOBODY (OOPS!). * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp: (GetOperatorString): * src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp: * src/libANGLE/renderer/metal/FrameBufferMtl.mm: (rx::FramebufferMtl::readPixels):
Dean Jackson
Comment 4 2021-03-16 14:54:38 PDT
Comment on attachment 423353 [details] Patch You're missing a changelog.
Kyle Piddington
Comment 5 2021-03-17 10:43:00 PDT
Created attachment 423501 [details] Patch
Kyle Piddington
Comment 6 2021-03-17 10:50:54 PDT
Created attachment 423502 [details] Patch
Dean Jackson
Comment 7 2021-03-17 13:44:42 PDT
Committed r274585 (235426@main): <https://commits.webkit.org/235426@main>
Radar WebKit Bug Importer
Comment 8 2021-03-17 13:45:22 PDT
<rdar://problem/75541805>
Note You need to log in before you can comment on or make changes to this bug.