Bug 223166

Summary: [JSC] Implement Temporal
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: REOPENED    
Severity: Normal CC: annulen, ap, benoit.rouleau, chi187, dev, dianeberlusconi, eric, ews-watchlist, gyuyoung.kim, ikerins, jarilittlenen, keith_miller, kyle.bavender, mark.lam, mehmetgelisin, m.goleb+bugzilla, moritz.mahringer, Ms2ger, msaboff, philip.chimento, ryuan.choi, saam, sergio, tjc, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=283825
Bug Depends on: 275897, 305603, 227643, 228532, 228658, 229651, 229703, 229826, 229892, 230033, 298561, 298562, 298563, 298564, 298565, 300365, 300389, 300423, 300458, 300640, 302903, 302974, 303243, 303245, 303413, 303503, 303799, 303899, 303947, 304093, 304190, 305021, 305061, 305156    
Bug Blocks:    
Attachments:
Description Flags
Dependency graph
none
Add empty Temporal and Temporal.now objects
none
Add empty Temporal and Temporal.now objects
none
Add empty Temporal and Temporal.now objects
none
Add empty Temporal and Temporal.now objects
none
Add empty Temporal and Temporal.now objects none

Yusuke Suzuki
Reported 2021-03-14 15:01:46 PDT
https://github.com/tc39/proposal-temporal
Attachments
Dependency graph (15.68 KB, application/pdf)
2021-06-14 21:17 PDT, Philip Chimento 		no flags
Details
Add empty Temporal and Temporal.now objects (14.10 KB, patch)
2021-07-02 13:28 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Add empty Temporal and Temporal.now objects (14.75 KB, patch)
2021-07-02 17:06 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Add empty Temporal and Temporal.now objects (21.38 KB, patch)
2021-07-05 17:11 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Add empty Temporal and Temporal.now objects (20.11 KB, patch)
2021-07-06 11:30 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Add empty Temporal and Temporal.now objects (20.11 KB, patch)
2021-07-06 11:51 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-22 04:36:35 PDT
<rdar://problem/75685318>
Philip Chimento
Comment 2 2021-06-14 21:17:17 PDT
Created attachment 431399 [details] Dependency graph Hi! I am planning to start contributing to this soon. I understand some of us will be working on it in parallel so I've planned out the dependencies between parts of Temporal in graphviz; see attachment. Looks like there are four places to start: Temporal.Instant, Temporal.Duration, Temporal.PlainTime, and Temporal.PlainDate/Temporal.Calendar together.
Philip Chimento
Comment 3 2021-07-02 13:28:23 PDT
Created attachment 432817 [details] Add empty Temporal and Temporal.now objects
Philip Chimento
Comment 4 2021-07-02 13:29:25 PDT
Comment on attachment 432817 [details] Add empty Temporal and Temporal.now objects I've added a boilerplate patch which should unblock the work in the dependency graph that I posted in comment 2. Let's discuss what to do next!
Keith Miller
Comment 5 2021-07-02 14:10:28 PDT
Looks, like we need to bump JSC's Unified source file count! I can upload a patch.
Keith Miller
Comment 6 2021-07-02 14:51:38 PDT
You should be able to retry your builds once https://bugs.webkit.org/show_bug.cgi?id=227643 lands.
Philip Chimento
Comment 7 2021-07-02 17:06:05 PDT
Created attachment 432833 [details] Add empty Temporal and Temporal.now objects
Yusuke Suzuki
Comment 8 2021-07-03 00:08:14 PDT
Comment on attachment 432833 [details] Add empty Temporal and Temporal.now objects Can you add h an cpp files to xcodeproj?
Philip Chimento
Comment 9 2021-07-05 17:11:44 PDT
Created attachment 432904 [details] Add empty Temporal and Temporal.now objects
Philip Chimento
Comment 10 2021-07-05 17:12:26 PDT
Comment on attachment 432904 [details] Add empty Temporal and Temporal.now objects I'm not very familiar with Xcode, but I hope this is correct.
Philip Chimento
Comment 11 2021-07-06 11:30:28 PDT
Created attachment 432952 [details] Add empty Temporal and Temporal.now objects
Philip Chimento
Comment 12 2021-07-06 11:51:35 PDT
Created attachment 432955 [details] Add empty Temporal and Temporal.now objects
EWS
Comment 13 2021-07-06 17:48:58 PDT
Committed r279630 (239448@main): <https://commits.webkit.org/239448@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432955 [details].
Philip Chimento
Comment 14 2021-07-06 19:14:07 PDT
Should be reopened, as this is just the beginning :-)
Yusuke Suzuki
Comment 15 2021-07-06 20:49:37 PDT
Committed r279638 (239452@main): <https://commits.webkit.org/239452@main>
Yusuke Suzuki
Comment 16 2021-07-07 12:43:04 PDT
Remain opening since attached patch is just a stub.
Philip Chimento
Comment 20 2025-04-09 11:39:24 PDT
Pull request: https://github.com/WebKit/WebKit/pull/43849
EWS
Comment 21 2025-04-10 08:43:45 PDT
Committed 293522@main (fec80ceedc41): <https://commits.webkit.org/293522@main> Reviewed commits have been landed. Closing PR #43849 and removing active labels.
EWS
Comment 22 2025-04-11 17:46:30 PDT
Committed 293612@main (9bf5fbaf1f2d): <https://commits.webkit.org/293612@main> Reviewed commits have been landed. Closing PR #43911 and removing active labels.
EWS
Comment 23 2025-04-15 07:17:46 PDT
Committed 293705@main (0c9c5585d939): <https://commits.webkit.org/293705@main> Reviewed commits have been landed. Closing PR #43993 and removing active labels.
EWS
Comment 24 2025-04-15 17:34:05 PDT
Committed 293742@main (09fe0b34ffb6): <https://commits.webkit.org/293742@main> Reviewed commits have been landed. Closing PR #44103 and removing active labels.
EWS
Comment 25 2025-04-17 16:49:01 PDT
Committed 293829@main (2a82bda90bd6): <https://commits.webkit.org/293829@main> Reviewed commits have been landed. Closing PR #44129 and removing active labels.
EWS
Comment 26 2025-04-18 12:20:47 PDT
Committed 293864@main (9dc6017a4421): <https://commits.webkit.org/293864@main> Reviewed commits have been landed. Closing PR #44132 and removing active labels.
EWS
Comment 27 2025-05-17 10:46:53 PDT
Committed 295056@main (ec92d4328cf1): <https://commits.webkit.org/295056@main> Reviewed commits have been landed. Closing PR #45348 and removing active labels.
Tim Chevalier
Comment 28 2025-05-19 09:29:14 PDT
This should be reopened as there are many more changes that need to be done. (I don't think I have permissions to do so.)
Keith Miller
Comment 29 2025-05-19 10:01:17 PDT
Reopened.
Keith Miller
Comment 30 2025-05-19 12:19:53 PDT
<rdar://151626148>
Tim Chevalier
Comment 31 2025-05-19 12:52:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/45603
EWS
Comment 32 2025-08-22 05:32:01 PDT
Committed 299050@main (4927ce289367): <https://commits.webkit.org/299050@main> Reviewed commits have been landed. Closing PR #45603 and removing active labels.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 33 2025-08-25 01:27:21 PDT
Still not done
Philip Chimento
Comment 34 2025-09-02 08:12:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/49776
EWS
Comment 35 2025-09-02 09:19:37 PDT
Committed 299436@main (707926f7f338): <https://commits.webkit.org/299436@main> Reviewed commits have been landed. Closing PR #49776 and removing active labels.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 36 2025-09-03 01:06:47 PDT
Still not done
Alexey Proskuryakov
Comment 37 2025-09-03 08:55:35 PDT
Would it be possible to use subtasks? Landing many changes under one bugzilla bug is unconventional, and not supported by tooling, as you can see.
Tim Chevalier
Comment 38 2025-09-04 16:14:22 PDT
(In reply to Alexey Proskuryakov from comment #37) > Would it be possible to use subtasks? Landing many changes under one > bugzilla bug is unconventional, and not supported by tooling, as you can see. I don't know how to use subtasks -- is there a guide somewhere? I expect there to be at least 50-60 more PRs for Temporal, so I'm open to doing whatever creates the least amount of overhead.
Alexey Proskuryakov
Comment 39 2025-09-05 09:37:12 PDT
A subtask would be just a separate bug that this one is marked as "depends on" (you can see that there are several of those already).
EWS
Comment 40 2025-09-05 14:11:46 PDT
Committed 299641@main (d2c65282e9e3): <https://commits.webkit.org/299641@main> Reviewed commits have been landed. Closing PR #50328 and removing active labels.
Tim Chevalier
Comment 41 2025-09-05 14:28:17 PDT
(In reply to Alexey Proskuryakov from comment #39) > A subtask would be just a separate bug that this one is marked as "depends > on" (you can see that there are several of those already). Ah, I see. I was avoiding that since I thought it might be too disruptive to create 50 separate bugs for each of the sub-PRs that will go into implementing Temporal. What do you think?
Alexey Proskuryakov
Comment 42 2025-09-05 17:36:08 PDT
That is better than attaching them all to this bug. Perhaps it's possible to do with fewer than 50, as well?
EWS
Comment 43 2025-09-08 16:06:57 PDT
Committed 299723@main (6fcf0414ac9c): <https://commits.webkit.org/299723@main> Reviewed commits have been landed. Closing PR #50388 and removing active labels.
Tim Chevalier
Comment 44 2025-09-08 16:07:13 PDT
I've created the following bugs, but I don't have Bugzilla permissions to edit the "depends on" for this bug. https://bugs.webkit.org/show_bug.cgi?id=298561 https://bugs.webkit.org/show_bug.cgi?id=298562 https://bugs.webkit.org/show_bug.cgi?id=298563 https://bugs.webkit.org/show_bug.cgi?id=298564 https://bugs.webkit.org/show_bug.cgi?id=298565 This is not comprehensive, but I'll create more as-needed.
Alexey Proskuryakov
Comment 45 2025-09-08 16:14:05 PDT
> I've created the following bugs, but I don't have Bugzilla permissions to edit the "depends on" for this bug. You have the permissions now. > This is not comprehensive, but I'll create more as-needed. For future ones, please don't clone, just create new clean bugs.
Tim Chevalier
Comment 46 2025-09-08 16:17:13 PDT
Thanks!
Note You need to log in before you can comment on or make changes to this bug.