Bug 222803

Summary:

GLib JSC API headers should only include other GLib JSC API headers

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

JavaScriptCore

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=222985

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
Patch	mcatanzaro: review+
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Don Olmstead

Reported 2021-03-05 07:48:53 PST

A number of private GLib JSC headers are directly including JavaScriptCore headers. They are being consumed as <jsc/JSCFooPrivate.h> in the InjectedBundle API code for GLib ports. However there are JavaScriptCore headers in there that are included as "Foo.h" which is wrong because when building WebKit that header needs to be included as <JavaScriptCore/Foo.h>. The fix should be forward declaring any JavaScriptCore specific constructs and only including files within API/glib relatively.

Attachments
WIP Patch (9.69 KB, patch) 2021-03-09 08:35 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (9.69 KB, patch) 2021-03-09 08:54 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (12.66 KB, patch) 2021-03-09 09:45 PST, Don Olmstead	mcatanzaro: review+	Details Formatted Diff Diff
Patch (18.75 KB, patch) 2021-03-09 11:00 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.08 KB, patch) 2021-03-09 13:14 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (19.50 KB, patch) 2021-03-09 13:14 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (21.83 KB, patch) 2021-03-09 20:41 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (21.87 KB, patch) 2021-03-09 21:43 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (22.42 KB, patch) 2021-03-09 22:15 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (22.59 KB, patch) 2021-03-09 22:22 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (22.67 KB, patch) 2021-03-09 22:37 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2021-03-09 08:35:25 PST Comment hidden (obsolete)

Created attachment 422703 [details] WIP Patch

EWS Watchlist

Comment 2 2021-03-09 08:36:12 PST Comment hidden (obsolete)

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Don Olmstead

Comment 3 2021-03-09 08:54:04 PST Comment hidden (obsolete)

Created attachment 422709 [details] WIP Patch

Don Olmstead

Comment 4 2021-03-09 09:45:49 PST Comment hidden (obsolete)

Created attachment 422720 [details] Patch

Michael Catanzaro

Comment 5 2021-03-09 09:52:02 PST

Comment on attachment 422720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422720&action=review > Source/JavaScriptCore/PlatformGTK.cmake:73 > + --warn-error I like.

Don Olmstead

Comment 6 2021-03-09 11:00:53 PST

Created attachment 422729 [details] Patch