Bug 222703

Summary: [Python 3] Update wpt/tools
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: gsnedders, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226703
https://bugs.webkit.org/show_bug.cgi?id=226746
Bug Depends on:    
Bug Blocks: 222188    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch for webkitpy none

Don Olmstead
Reported 2021-03-03 17:48:38 PST
Last update was back in May of 2020.
Attachments
WIP Patch (9.54 MB, patch)
2021-03-03 17:54 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (9.56 MB, patch)
2021-03-03 18:00 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch for webkitpy (1.55 KB, patch)
2021-03-03 19:07 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-03-03 17:54:01 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2021-03-03 18:00:11 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2021-03-03 19:07:37 PST
Created attachment 422172 [details] Patch for webkitpy
Don Olmstead
Comment 4 2021-03-03 19:14:14 PST
I verified that the code in an updated wpt/tools directory runs with Windows + Python 3. There is still an outstanding issue around a config.json for the tests but that problem is in webkitpy not wpt/tools. I used this commit https://github.com/web-platform-tests/wpt/commit/5c496d309c2d31c9867ef7a5023a6f7021ba0751 from 2020-03-03 which has two fixes for Windows. That or anything later should be fine. Looks like the EWS can't handle the patch though. This might have to do with renames since I had to update my git config, diff.renameLimit and merge.renameLimit, to output the patch at all.
Radar WebKit Bug Importer
Comment 5 2021-03-10 17:49:16 PST
<rdar://problem/75293158>
Sam Sneddon [:gsnedders]
Comment 6 2021-07-05 14:58:10 PDT
*** This bug has been marked as a duplicate of bug 227255 ***
Note You need to log in before you can comment on or make changes to this bug.