Bug 222173

Summary: Implement OpenXR port graphics binding
Product: WebKit Reporter: Imanol Fernandez <ifernandez>
Component: WebXRAssignee: Imanol Fernandez <ifernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, annulen, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 222263    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
svillar: review+, svillar: commit-queue-
Patch for landing none

Imanol Fernandez
Reported 2021-02-19 07:55:58 PST
Headless session is not valid for tracking or rendering, and we need a graphics binding to create a non headless XrSession.
Attachments
Patch (64.94 KB, patch)
2021-02-19 08:33 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (25.06 KB, patch)
2021-02-24 07:07 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (25.06 KB, patch)
2021-02-24 07:09 PST, Imanol Fernandez 		svillar: review+
svillar: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (24.62 KB, patch)
2021-02-26 02:39 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Imanol Fernandez
Comment 1 2021-02-19 08:33:35 PST
Created attachment 420972 [details] Patch
Imanol Fernandez
Comment 2 2021-02-22 02:39:18 PST
Comment on attachment 420972 [details] Patch I splitted the file refactor into a different patch: https://bugs.webkit.org/show_bug.cgi?id=222263 I'll rebase this one when 222264 is merged
Imanol Fernandez
Comment 3 2021-02-24 07:07:35 PST
Created attachment 421405 [details] Patch Rebase onto main
Imanol Fernandez
Comment 4 2021-02-24 07:09:30 PST
Created attachment 421406 [details] Patch Fix nit in changelog
Sergio Villar Senin
Comment 5 2021-02-26 02:12:20 PST
Comment on attachment 421406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421406&action=review > Source/WebCore/platform/xr/openxr/OpenXRExtensions.cpp:78 > + reinterpret_cast<PFN_xrVoidFunction*>(&m_methods.xrGetOpenGLGraphicsRequirementsKHR)); Use a single line here > Source/WebCore/platform/xr/openxr/OpenXRUtils.h:30 > +typedef __eglMustCastToProperFunctionPointerType (*PFNEGLGETPROCADDRESSPROC)(const char *proc); Seems superweird having to add this. Style wise the asterisk should go always next to the type, void *EGL -> void* EGL, char *... etc > Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:265 > + return features; So this is how we avoid having to create the session too early. nice! I should have researched a bit more about it.
Imanol Fernandez
Comment 6 2021-02-26 02:39:47 PST
Created attachment 421630 [details] Patch for landing Address review feedback
EWS
Comment 7 2021-02-26 03:53:12 PST
Committed r273549: <https://commits.webkit.org/r273549> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421630 [details].
Radar WebKit Bug Importer
Comment 8 2021-02-26 03:54:13 PST
<rdar://problem/74785342>
Note You need to log in before you can comment on or make changes to this bug.