Bug 222020
| Summary: | REGRESSION(r272776) [GLIB] imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.broken.html is failing for a different reason | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | Canvas | Assignee: | Rob Buis <rbuis> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dino, sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=221637 | ||
Lauro Moura
imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.broken.html
This test checks if ctx.createPattern(brokenImage, ...) returns null with a broken image[1]. While the current baseline expects FAIL, r272776 changed the reason it's failing in GTK/WPE.
Diff:
-FAIL Canvas test: 2d.pattern.image.broken assert_equals: ctx.createPattern(img, 'repeat') === null (got [object CanvasPattern][object], expected [object]) expected null but got object "[object CanvasPattern]"
+FAIL Canvas test: 2d.pattern.image.broken The object is in an invalid state.
The invalid state is raised after failing to create the native image in CanvasRenderingContext2DBase::createPattern(HTMLImageElement...).
Meanwhile, the same revision made imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.nonexistent.html pass in WPE, as now InvalidState is thrown.
[1] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createpattern
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/74675235>
Rob Buis
Pull request: https://github.com/WebKit/WebKit/pull/37969
EWS
Committed 288110@main (7702ba882df2): <https://commits.webkit.org/288110@main>
Reviewed commits have been landed. Closing PR #37969 and removing active labels.