Bug 221685

Summary:

[GPUP] Some modern-media-controls tests are flaky when media in GPU Process is enabled

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

Media

Assignee:

Peng Liu <peng.liu6>

Status:

REOPENED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jer.noble, jonlee, peng.liu6, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=183490
https://bugs.webkit.org/show_bug.cgi?id=221830

Attachments:

Description	Flags
Remove passing tests from test expectations	none
Fix two flaky tests and update test expectations	none
Two tests are passing consistently now	ews-feeder: commit-queue-

Peng Liu

Reported 2021-02-10 10:05:51 PST

media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html media/modern-media-controls/fullscreen-support/fullscreen-support-press.html media/modern-media-controls/media-controller/media-controller-auto-hide.html media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html media/modern-media-controls/media-controller/media-controller-fullscreen-change.html media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html media/modern-media-controls/placard/placard-ltr.html media/modern-media-controls/scrubber-support/scrubber-support-drag.html media/modern-media-controls/seek-backward-support/seek-backward-support.html

Attachments
Remove passing tests from test expectations (2.61 KB, patch) 2021-03-01 15:35 PST, Peng Liu	no flags	Details Formatted Diff Diff
Fix two flaky tests and update test expectations (10.67 KB, patch) 2021-03-10 21:21 PST, Peng Liu	no flags	Details Formatted Diff Diff
Two tests are passing consistently now (2.45 KB, patch) 2021-03-16 10:23 PDT, Peng Liu	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-02-17 10:06:14 PST

<rdar://problem/74438431>

Peng Liu

Comment 2 2021-02-25 16:50:16 PST

http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Timeout ] http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html [ Timeout ] http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html [ Timeout ] http/tests/media/modern-media-controls/skip-back-support/skip-back-support-live-broadcast.html [ Timeout ] http/tests/media/modern-media-controls/status-support/status-support-live-broadcast.html [ Timeout ] http/tests/media/modern-media-controls/time-control/1-to-10-hours.html [ Timeout ] http/tests/media/modern-media-controls/time-control/10-hours-or-more.html [ Timeout ] http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html [ Timeout ] http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html [ Timeout ]

Peng Liu

Comment 3 2021-03-01 15:35:17 PST

Created attachment 421878 [details] Remove passing tests from test expectations

EWS

Comment 4 2021-03-01 16:10:06 PST

Committed r273701: <https://commits.webkit.org/r273701> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421878 [details].

Peng Liu

Comment 5 2021-03-01 16:15:03 PST

Reopen this bug because there are still some failing tests.

Peng Liu

Comment 6 2021-03-04 14:09:17 PST

Following two tests are passing consistently now: http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html media/modern-media-controls/fullscreen-support/fullscreen-support-press.html

Peng Liu

Comment 7 2021-03-10 21:21:45 PST

Created attachment 422899 [details] Fix two flaky tests and update test expectations

EWS

Comment 8 2021-03-11 09:12:18 PST

Committed r274281: <https://commits.webkit.org/r274281> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422899 [details].

Peng Liu

Comment 9 2021-03-11 09:14:20 PST

Reopen this bug because there are 9 remaining test failures.

Peng Liu

Comment 10 2021-03-16 10:23:30 PDT

Created attachment 423352 [details] Two tests are passing consistently now

EWS

Comment 11 2021-03-16 10:30:32 PDT

/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Peng Liu

Comment 12 2021-03-16 10:45:39 PDT

Committed r274492 (235348@main): <https://commits.webkit.org/235348@main>

Note You need to log in before you can comment on or make changes to this bug.