Bug 221637

Summary: Make Pattern hold a NativeImage instead of an Image
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, hi, joepeck, kondapallykalyan, pdr, schenney, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222020
Bug Depends on:    
Bug Blocks: 219468    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
simon.fraser: review+
Patch none

Said Abou-Hallawa
Reported 2021-02-09 15:17:43 PST
This is step towards the fix of bug 219468. This will make caching the Pattern data in the GPUP straightforward since we need to cache the NativeImage and send the pattern data.
Attachments
Patch (43.63 KB, patch)
2021-02-09 16:14 PST, Said Abou-Hallawa
no flags
Patch (43.87 KB, patch)
2021-02-09 16:35 PST, Said Abou-Hallawa
ews-feeder: commit-queue-
Patch (43.93 KB, patch)
2021-02-09 17:01 PST, Said Abou-Hallawa
no flags
Patch (43.93 KB, patch)
2021-02-09 17:25 PST, Said Abou-Hallawa
no flags
Patch (43.92 KB, patch)
2021-02-09 18:56 PST, Said Abou-Hallawa
no flags
Patch (58.94 KB, patch)
2021-02-11 21:45 PST, Said Abou-Hallawa
simon.fraser: review+
Patch (59.04 KB, patch)
2021-02-12 00:07 PST, Said Abou-Hallawa
no flags
Said Abou-Hallawa
Comment 1 2021-02-09 16:14:43 PST
Said Abou-Hallawa
Comment 2 2021-02-09 16:35:37 PST
Said Abou-Hallawa
Comment 3 2021-02-09 17:01:45 PST
Said Abou-Hallawa
Comment 4 2021-02-09 17:25:30 PST
Said Abou-Hallawa
Comment 5 2021-02-09 18:56:46 PST
Said Abou-Hallawa
Comment 6 2021-02-11 21:45:45 PST
Simon Fraser (smfr)
Comment 7 2021-02-11 23:07:28 PST
Comment on attachment 420097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420097&action=review > Source/WebCore/platform/graphics/Pattern.h:70 > + bool repeatX; > + bool repeatY; > + AffineTransform patternSpaceTransform; Putting the bools after the transform will eliminate some padding.
Said Abou-Hallawa
Comment 8 2021-02-12 00:07:25 PST
EWS
Comment 9 2021-02-12 01:10:44 PST
Committed r272776: <https://commits.webkit.org/r272776> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420101 [details].
Radar WebKit Bug Importer
Comment 10 2021-02-12 01:11:15 PST
Note You need to log in before you can comment on or make changes to this bug.