Bug 221274

Summary: Adjust EventHandler to account for image extraction content
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
For landing none

Description Wenson Hsieh 2021-02-02 10:51:30 PST
See radar for more detail.
Comment 1 Wenson Hsieh 2021-02-07 14:13:29 PST
Created attachment 419548 [details]
Patch
Comment 2 Tim Horton 2021-02-08 10:18:03 PST
Comment on attachment 419548 [details]
Patch

Should we make the element method behavioral instead of identifying?
Comment 3 Wenson Hsieh 2021-02-08 10:34:03 PST
(In reply to Tim Horton from comment #2)
> Comment on attachment 419548 [details]
> Patch
> 
> Should we make the element method behavioral instead of identifying?

Sounds good! Changed isImageOverlayContainer to shouldUpdateSelectionForMouseDrag, and made it take the previous VisibleSelection (selectionBeforeUpdate).
Comment 4 Wenson Hsieh 2021-02-08 10:55:17 PST
Created attachment 419605 [details]
For landing
Comment 5 EWS 2021-02-08 11:43:35 PST
Committed r272503: <https://commits.webkit.org/r272503>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419605 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-10 14:43:31 PST
<rdar://problem/74207111>