| Summary: | [WPE] Some more dependencies mising in Tools/wpe/install-dependencies | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eleni Maria Stea <estea> | ||||||||
| Component: | Tools / Tests | Assignee: | Eleni Maria Stea <estea> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Minor | CC: | aperez, clopez, estea, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eleni Maria Stea
2021-02-02 05:28:39 PST
Created attachment 418985 [details]
proposed patch for Tools dependencies
python-psutil is replaced with python3-psutil that is present in
Diebian/Ubuntu/Raspbian. libegl-mesa0 is added in the dependencies
list as it's required for libegl1-mesa-dev to be installed.
Comment on attachment 418985 [details] proposed patch for Tools dependencies Patch looks fine, but you need to edit the ChangeLog before we can accept it. The “webkit-patch” script (or “prepare-ChangeLog”) can check your local changes and generate a skeleton of the edits in the ChangeLog that then you can fill in. There is a walkthrough here: https://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit Feel free to ask if you get stuck :) Created attachment 419127 [details]
modified the patch and updated the Changelog
Thank you for the review and the guidelines!
I've updated my patch and the Changelog.
Adrian Perez found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). (In reply to Eleni Maria Stea from comment #3) > Created attachment 419127 [details] > modified the patch and updated the Changelog > > Thank you for the review and the guidelines! > I've updated my patch and the Changelog. Approved, thanks! (In reply to EWS from comment #4) > Adrian Perez found in > /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to > be a valid reviewer according to contributors.json. > /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a > valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case > insensitive). Gah! The commit-queue failed because the line: “Reviewed by Adrian Perez.” …should have been instead: “Reviewed by Adrian Perez de Castro.” (Reviewer names are checked against the contents of the “Tools/Scripts/webkitpy/common/config/contributors.json” file.) Another option is to leave the line as: ”Reviewed by OOOPS.” …and then when a reviewer sets the “r+” flag in Bugzilla, the commit queue will edit the ChangeLog and replace “OOOPS” with the name of the reviewer. Created attachment 419262 [details]
Patch for landing
I have posted a version with the “Reviewed by” line edited to contain the correct name, to let the commit queue handle the landing. (In reply to Adrian Perez from comment #8) > I have posted a version with the “Reviewed by” line edited to > contain the correct name, to let the commit queue handle the > landing. Thanks! And apologies I mistyped your name! Committed r272365: <https://trac.webkit.org/changeset/272365> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419262 [details]. (In reply to Eleni Maria Stea from comment #9) > (In reply to Adrian Perez from comment #8) > > I have posted a version with the “Reviewed by” line edited to > > contain the correct name, to let the commit queue handle the > > landing. > > Thanks! And apologies I mistyped your name! No problem at all =] |