| Summary: | Completion value of a finally block should not be ignored if completion is abrupt | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ross Kirsling
2021-02-01 18:12:02 PST
Created attachment 418950 [details]
Patch
Created attachment 418952 [details]
Patch
Created attachment 418953 [details]
Patch
Comment on attachment 418953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418953&action=review r=me > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4560 > + int finallyStartOffset = m_catchBlock ? m_catchBlock->endOffset() + 1 : m_tryBlock->endOffset() + 1; Let's put this before this if-else. Created attachment 419047 [details]
Patch for landing
Committed r272243: <https://trac.webkit.org/changeset/272243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419047 [details]. |