Bug 221235

Summary: ews isn't retrying builds when kill-old-processes fails
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, jlewis3, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Aakash Jain 2021-02-01 17:28:40 PST 
ews isn't retrying builds when kill old process fails. e.g.: https://ews-build.webkit.org/#/builders/56/builds/196 didn't resulted in retry.

Retry on kill-old-process failure was added in https://trac.webkit.org/changeset/252324/webkit which was working fine. But seems like https://trac.webkit.org/r257654 broke it.
Comment 1 Aakash Jain 2021-02-01 17:31:52 PST 
Created attachment 418944 [details]
Patch
Comment 2 Aakash Jain 2021-02-02 02:37:13 PST 
Sample run: https://ews-build.webkit-uat.org/#/builders/13/builds/3883
Comment 3 EWS 2021-02-02 03:12:21 PST 
Committed r272204: <https://trac.webkit.org/changeset/272204>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418944 [details].
Comment 4 Radar WebKit Bug Importer 2021-02-02 03:13:13 PST 
<rdar://problem/73872929>
Comment 5 Aakash Jain 2021-02-22 07:23:52 PST 
This seems to work fine. For e.g: https://ews-build.webkit.org/#/builders/58/builds/2278 was retried when kill-old-processes failed (as bot was in bad state).