| Summary: | Only update IPC connection of RemoteCaptureSampleManager for audio sources | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2021-02-01 05:17:24 PST
Created attachment 418861 [details]
Patch
Comment on attachment 418861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201 > void UserMediaCaptureManager::didUpdateSourceConnection(RemoteRealtimeMediaSource& source) > { > - m_remoteCaptureSampleManager.didUpdateSourceConnection(source); > + if (source.type() == RealtimeMediaSource::Type::Audio) > + m_remoteCaptureSampleManager.didUpdateSourceConnection(source); > } It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is? Comment on attachment 418861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review >> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201 >> } > > It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is? Right, let's rename m_remoteCaptureSampleManager to m_remoteAudioCaptureSampleManager. Created attachment 418974 [details]
Patch for landing
commit-queue failed to commit attachment 418974 [details] to WebKit repository.
commit-queue failed to commit attachment 418974 [details] to WebKit repository.
Committed r272205: <https://trac.webkit.org/changeset/272205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418974 [details]. |