| Summary: | CeilingOnPageSize too low for Loongson CPUs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | angelos, benjamin, berto, cdumez, chengzhpchn, cmarcelo, ews-watchlist, mcatanzaro, webkit-bug-importer, xan.lopez | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alberto Garcia
2021-02-01 02:26:46 PST
Our guess is that we are crashing in WTF::pageSize():
RELEASE_ASSERT_WITH_MESSAGE(s_pageSize <= CeilingOnPageSize, "CeilingOnPageSize is too low, raise it in PageBlock.h!");
For Loongson CPUs that will be 16 <= 4, which won't work.
We can change the general ceiling value for MIPS to something else, at least 16KB, or try to detect Loongson CPUs and change it just for those.
(In reply to Xan Lopez from comment #1) > We can change the general ceiling value for MIPS to something else, > at least 16KB, or try to detect Loongson CPUs and change it just for > those. For distributions I don't think the latter is an option, because there's no guarantee that the machine where the package is built is the same where it is installed and run. But I can patch that downstream if there's no good general solution. This was fixed for 32-bit MIPS in r276583 (bug 225030), I think we should also do it for MIPS64. (In reply to Alberto Garcia from comment #4) > This was fixed for 32-bit MIPS in r276583 (bug 225030), I think we should > also do it for MIPS64. Do it! Created attachment 428747 [details]
Patch
Committed r277551 (237779@main): <https://commits.webkit.org/237779@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428747 [details]. *** Bug 223721 has been marked as a duplicate of this bug. *** |