Bug 221149

Summary: SourceParseMode should be a member of the JSC::Parser
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2021-01-29 12:57:38 PST
SourceParseMode should be a member of the JSC::Parser
Attachments
Patch (43.97 KB, patch)
2021-01-29 12:59 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (44.10 KB, patch)
2021-01-29 14:15 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (44.10 KB, patch)
2021-01-29 14:16 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2021-01-29 12:59:51 PST
Created attachment 418762 [details] Patch
Ross Kirsling
Comment 2 2021-01-29 14:06:57 PST
Comment on attachment 418762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418762&action=review LGTM overall. > Source/JavaScriptCore/parser/Parser.h:1172 > + using ParseModeScope = SetForScope<SourceParseMode>; I think this might be more confusing than helpful.
Keith Miller
Comment 3 2021-01-29 14:15:43 PST
Created attachment 418771 [details] Patch
Keith Miller
Comment 4 2021-01-29 14:16:57 PST
Created attachment 418772 [details] Patch for landing
EWS
Comment 5 2021-01-29 16:36:12 PST
Committed r272086: <https://trac.webkit.org/changeset/272086> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418772 [details].
Radar WebKit Bug Importer
Comment 6 2021-01-29 16:37:13 PST
<rdar://problem/73777391>
Note You need to log in before you can comment on or make changes to this bug.