| Summary: | SourceParseMode should be a member of the JSC::Parser | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Keith Miller
2021-01-29 12:57:38 PST
Created attachment 418762 [details]
Patch
Comment on attachment 418762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418762&action=review LGTM overall. > Source/JavaScriptCore/parser/Parser.h:1172 > + using ParseModeScope = SetForScope<SourceParseMode>; I think this might be more confusing than helpful. Created attachment 418771 [details]
Patch
Created attachment 418772 [details]
Patch for landing
Committed r272086: <https://trac.webkit.org/changeset/272086> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418772 [details]. |