Bug 221138

Summary: Recover WebRTC codecs in case of GPUProcess crash
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2021-01-29 09:06:31 PST 
Recover WebRTC codecs in case of GPUProcess crash
Comment 1 youenn fablet 2021-01-29 09:15:37 PST 
Created attachment 418735 [details]
Patch
Comment 2 youenn fablet 2021-01-29 12:42:47 PST 
Created attachment 418757 [details]
Patch
Comment 3 youenn fablet 2021-01-29 13:24:50 PST 
Created attachment 418765 [details]
Patch
Comment 4 youenn fablet 2021-02-01 00:47:34 PST 
Created attachment 418840 [details]
Patch
Comment 5 Eric Carlson 2021-02-01 09:00:16 PST 
Comment on attachment 418840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418840&action=review

``

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:473
> +    m_queue->dispatch([this, connection = makeRef(gpuConnection.connection())] {

Nit: why not `dispatchToThread` as you do elsewhere?
Comment 6 youenn fablet 2021-02-02 02:08:29 PST 
Created attachment 418975 [details]
Patch for landing
Comment 7 EWS 2021-02-02 03:00:19 PST 
Committed r272202: <https://trac.webkit.org/changeset/272202>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418975 [details].
Comment 8 Radar WebKit Bug Importer 2021-02-02 03:01:18 PST 
<rdar://problem/73872551>