Bug 221128

Summary: Recover MediaStreamTrack audio rendering from GPUProcess crash
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, peng.liu6, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2021-01-29 04:53:31 PST 
Recover MediaStreamTrack audio rendering from GPUProcess crash
Comment 1 youenn fablet 2021-01-29 04:59:04 PST 
Created attachment 418718 [details]
Patch
Comment 2 youenn fablet 2021-01-29 08:47:51 PST 
Comment on attachment 418718 [details]
Patch

WK1 failure is unrelated
Comment 3 Radar WebKit Bug Importer 2021-02-01 11:28:49 PST 
<rdar://problem/73838195>
Comment 4 Peng Liu 2021-02-01 15:33:13 PST 
Comment on attachment 418718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418718&action=review

> Source/WebCore/platform/mediastream/AudioMediaStreamTrackRenderer.h:108
> +

Nit. An extra empty line.

> Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:172
> +void AudioTrackPrivateMediaStream::createNewRenderer()

Nit. Seems a callback. Maybe we can name it "newRendererCreated"?
Comment 5 youenn fablet 2021-02-02 02:14:18 PST 
(In reply to Peng Liu from comment #4)
> Comment on attachment 418718 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418718&action=review
> 
> > Source/WebCore/platform/mediastream/AudioMediaStreamTrackRenderer.h:108
> > +
> 
> Nit. An extra empty line.

Will fix.

> > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:172
> > +void AudioTrackPrivateMediaStream::createNewRenderer()
> 
> Nit. Seems a callback. Maybe we can name it "newRendererCreated"?

Not really, it is actually creating a new renderer, even though this is triggered by a callback telling current renderer is crashing.
Comment 6 youenn fablet 2021-02-02 02:14:40 PST 
Created attachment 418977 [details]
Patch
Comment 7 EWS 2021-02-02 09:21:27 PST 
Committed r272213: <https://trac.webkit.org/changeset/272213>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418977 [details].