| Summary: | Add plumbing to allow AppHighlights to be restored. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | hi, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Megan Gardner
2021-01-28 23:56:26 PST
Created attachment 418710 [details]
Patch
Comment on attachment 418710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418710&action=review > Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:255 > + return; You can just delete this now > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:366 > +- (void)_restoreAppHighlights:(NSData *)data WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); I would put a newline between this and the family of methods above. > Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:547 > + IPC::SharedBufferDataReference dataReference {data}; Spaces inside the { } > Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:550 > + if (!hasRunningProcess()) > + return; Seems like this should come first. > Source/WebKit/WebProcess/WebPage/WebPage.cpp:7191 > +void WebPage::restoreAppHighlights(const IPC::DataReference& data) Newline before this. Comment on attachment 418710 [details]
Patch
I'm not sure all the SharedBuffer machinations are right, it would be good if someone who'd touched it recently could peek (things look slightly different than I remember).
Comment on attachment 418710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418710&action=review LGTM with Tim's comments. > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2048 > + _page->restoreAppHighlights(WTFMove(buffer)); Nit - I would just write this as `_page->restoreAppHighlights(WebCore::SharedBuffer::create(data));`. Created attachment 418738 [details]
Patch
Created attachment 418796 [details]
Patch for landing
Committed r272096: <https://trac.webkit.org/changeset/272096> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418796 [details]. |