Bug 221109

Summary:

Pass full environment when auto installing a Python module on Windows

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Tools / Tests

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, don.olmstead, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

221815

Attachments:

Description	Flags
WIP patch	ews-feeder: commit-queue-
Patch	none

Description Fujii Hironori 2021-01-28 16:33:09 PST

Win32 Python3 fails installing markupsafe-2.0.0: error: [WinError 3] The system cannot find the path specified: 'Microsoft.NET\\Framework64'

Downloading markupsafe-2.0.0...
Installing markupsafe-2.0.0...
running install
running build
running build_py
creating build
creating build\lib.win-amd64-3.9
creating build\lib.win-amd64-3.9\markupsafe
copying src\markupsafe\_native.py -> build\lib.win-amd64-3.9\markupsafe
copying src\markupsafe\__init__.py -> build\lib.win-amd64-3.9\markupsafe
running egg_info
writing src\MarkupSafe.egg-info\PKG-INFO
writing dependency_links to src\MarkupSafe.egg-info\dependency_links.txt
writing top-level names to src\MarkupSafe.egg-info\top_level.txt
reading manifest file 'src\MarkupSafe.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'docs\_build'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
writing manifest file 'src\MarkupSafe.egg-info\SOURCES.txt'
copying src\markupsafe\_speedups.c -> build\lib.win-amd64-3.9\markupsafe
running build_ext
building 'markupsafe._speedups' extension
error: [WinError 3] The system cannot find the path specified: 'Microsoft.NET\\Framework64'
Failed to install markupsafe-2.0.0!
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 919, in _find_spec
AttributeError: type object 'AutoInstall' has no attribute 'find_spec'

WinCairo bots are using Win32 Python instead of Cygwin Python.

Comment 1 Fujii Hironori 2021-01-28 17:06:28 PST

https://github.com/pypa/setuptools/blob/main/setuptools/msvc.py
refers some env vars.

Comment 2 Fujii Hironori 2021-01-28 17:17:05 PST

Created attachment 418683 [details]
WIP patch

Comment 3 Jonathan Bedard 2021-01-29 09:03:58 PST

Talking with Don on Slack, I think markupsafe should be 1.1.1, I messed up version locking 2.0.0, which is an alpha version.

Comment 4 Don Olmstead 2021-01-29 14:32:48 PST

(In reply to Jonathan Bedard from comment #3)
> Talking with Don on Slack, I think markupsafe should be 1.1.1, I messed up
> version locking 2.0.0, which is an alpha version.

Python 3.9 seems to want to download the 2.0.0 version, probably due to compatibility. This patch though does clear it up and it does install successfully.

Comment 5 Radar WebKit Bug Importer 2021-02-04 16:34:12 PST

<rdar://problem/74002781>

Comment 6 Don Olmstead 2021-02-23 12:00:57 PST

Created attachment 421337 [details]
Patch

Comment 7 EWS 2021-02-23 13:36:12 PST

Committed r273331: <https://commits.webkit.org/r273331>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421337 [details].