Bug 221043

Summary:

[Flatpak SDK] Get rid of Python2

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, ews-watchlist, glenn, jbedard, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226658

Bug Depends on:

203701

Bug Blocks:

Attachments:

Description	Flags
Patch	none
[fast-cq] Patch	none

Philippe Normand

Reported 2021-01-27 07:33:28 PST

https://bugs.webkit.org/show_bug.cgi?id=221029#c4

Attachments
Patch (5.78 KB, patch) 2021-01-27 09:25 PST, Philippe Normand	no flags	Details Formatted Diff Diff
[fast-cq] Patch (5.88 KB, patch) 2022-03-13 10:02 PDT, Philippe Normand	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2021-01-27 07:34:12 PST

This probably depends on bug #203701, if that's still an issue. Should probably not be hard, though....

Philippe Normand

Comment 2 2021-01-27 09:25:16 PST

Created attachment 418554 [details] Patch

Philippe Normand

Comment 3 2021-01-27 09:26:18 PST

With this WIP patch some tests are now timing-out. Investigation pending. Reproducer: WEBKIT_FLATPAK_USER_DIR=$PWD/WebKitBuild/UserFlatpak.Local run-webkit-tests --gtk --no-retry-failures --no-show-results --verbose --details --debug-rwt-logging media/muted-video-is-playing-audio.html

Jonathan Bedard

Comment 4 2021-01-27 11:27:00 PST

Apple doesn't use Flatpak, so this doesn't effect the configurations I work with, but it's worth noting that run-webkit-tests still has an issue with multiprocessing that prevents it from running with Python 3.8. It's on my list of things to work on in the near future, but this is what is preventing Apple's infrastructure from dropping Python 2 support, not sure how relevant that is here.

Philippe Normand

Comment 5 2021-01-27 11:44:55 PST

Thanks Jonathan! This might be relevant indeed because our SDK ships Python 3.8. Do you know if 3.9 is supposed to work with the existing r-w-t? In which case we could update to that version in our SDK.

Jonathan Bedard

Comment 6 2021-01-27 11:56:39 PST

(In reply to Philippe Normand from comment #5) > Thanks Jonathan! This might be relevant indeed because our SDK ships Python > 3.8. Do you know if 3.9 is supposed to work with the existing r-w-t? In > which case we could update to that version in our SDK. Have not tested, but it's definitely going to have the same problem. The issue is that newer versions of Python aren't using fork(), so everything needs to be pickle-able to be passed to child processes.

Philippe Normand

Comment 7 2021-07-08 04:50:04 PDT

I checked this recently, the layout tests run fine on Python3, excepted the http ones which require the python2 websocket server.

Carlos Alberto Lopez Perez

Comment 8 2021-07-08 17:24:18 PDT

(In reply to Philippe Normand from comment #7) > I checked this recently, the layout tests run fine on Python3, excepted the > http ones which require the python2 websocket server. See also bug 226658

Philippe Normand

Comment 9 2022-03-13 10:02:44 PDT

Created attachment 454555 [details] [fast-cq] Patch

EWS

Comment 10 2022-03-14 02:21:32 PDT

Committed r291219 (248374@main): <https://commits.webkit.org/248374@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454555 [details].

Radar WebKit Bug Importer

Comment 11 2022-03-14 02:22:16 PDT

<rdar://problem/90236251>

Note You need to log in before you can comment on or make changes to this bug.