| Summary: | [MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sam, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220826 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 220966 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2021-01-27 05:36:17 PST
Created attachment 418535 [details]
Patch
Created attachment 418628 [details]
Patch
Comment on attachment 418628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418628&action=review > Tools/ChangeLog:9 > + On iOS, capture ill still happen inprocess for the time being. s/ill/still/ Comment on attachment 418628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418628&action=review > Tools/WebKitTestRunner/TestController.cpp:933 > +#if PLATFORM(MAC) > + WKPreferencesSetCaptureAudioInGPUProcessEnabled(preferences, true); > + WKPreferencesSetCaptureVideoInGPUProcessEnabled(preferences, true); > +#endif Please keep this in TestOptions.cpp. Trying to have all the state in one place moving away from having it here. Created attachment 418663 [details]
Patch
Committed r272053: <https://trac.webkit.org/changeset/272053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418663 [details]. |