| Summary: | [iOS] expose existing macOS-only `-[WKWebView _pageExtendedBackgroundColor]` SPI | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | WebKit API | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hi, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220944 | ||||||
| Attachments: |
|
||||||
|
Description
Devin Rousso
2021-01-26 15:49:30 PST
Created attachment 418491 [details]
Patch
Comment on attachment 418491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418491&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:383 > +@property (nonatomic, readonly) NSColor *_pageExtendedBackgroundColor; Might as well rectify past mistakes and add the availability for the macOS version too (blame the line and see when it was introduced). Comment on attachment 418491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418491&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:383 >> +@property (nonatomic, readonly) NSColor *_pageExtendedBackgroundColor; > > Might as well rectify past mistakes and add the availability for the macOS version too (blame the line and see when it was introduced). AFAICT this appears to have existed as long as `WKWebView` has existed. It was added seven years ago in r165083. Committed r271969: <https://trac.webkit.org/changeset/271969> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418491 [details]. |