Bug 220987

Summary: Web Inspector: add Box Model into Layout panel
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+, bburg: commit-queue-
[Video] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2021-01-26 09:51:52 PST
I'm going to add Box Model to the experimental Layout panel. Once Layout panel is enabled by default, the plan is to remove Box Model from the Computed panel. <rdar://problem/73503841>
Attachments
Patch (4.02 KB, patch)
2021-02-01 14:11 PST, Nikita Vasilyev 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
[Video] With patch applied (4.89 MB, video/quicktime)
2021-02-01 14:12 PST, Nikita Vasilyev 		no flags
Details
Patch (4.17 KB, patch)
2021-02-01 15:34 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2021-02-01 14:11:36 PST
Created attachment 418920 [details] Patch
Nikita Vasilyev
Comment 2 2021-02-01 14:12:03 PST
Created attachment 418921 [details] [Video] With patch applied
Blaze Burg
Comment 3 2021-02-01 14:51:00 PST
Comment on attachment 418920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418920&action=review r=me with some little things > Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:43 > + return hasDOMNode; Nit: I prefer `return false`, it's easier to understand without any context. > Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:91 > // FIXME: Move the Box Model section here from the Computed panel. Nit: remove the FIXME > Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:106 > // Private I believe this needs to be ported over as well: get minimumWidth() { return this._boxModelDiagramRow?.minimumWidth ?? 0; }
Devin Rousso
Comment 4 2021-02-01 15:01:27 PST
Comment on attachment 418920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418920&action=review > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: move Box Model into Layout panel Seeing as how this patch doesn't touch the Computed panel, I'd rename the bug "add" instead of "move" (the latter implies that it's taken from it's old location, which is not the case as I mentioned).
Nikita Vasilyev
Comment 5 2021-02-01 15:34:11 PST
Created attachment 418935 [details] Patch
EWS
Comment 6 2021-02-01 18:10:42 PST
Committed r272182: <https://trac.webkit.org/changeset/272182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418935 [details].
Note You need to log in before you can comment on or make changes to this bug.