Bug 220968

Summary: Resync web-platform-tests/css/css-sizing/aspect-ratio from upstream
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, rego, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Rob Buis 2021-01-26 02:38:31 PST 
Resync web-platform-tests/css/css-sizing/aspect-ratio from upstream
Comment 1 Rob Buis 2021-01-26 02:47:32 PST 
Created attachment 418385 [details]
Patch
Comment 2 Rob Buis 2021-01-26 02:51:18 PST 
Created attachment 418386 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2021-01-26 03:53:29 PST 
Comment on attachment 418386 [details]
Patch

r=me, but please wait for green EWSs before landing.
Comment 4 Rob Buis 2021-01-26 05:32:27 PST 
Created attachment 418402 [details]
Patch
Comment 5 EWS 2021-01-26 12:25:13 PST 
Committed r271893: <https://trac.webkit.org/changeset/271893>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418402 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-26 12:26:18 PST 
<rdar://problem/73627884>
Comment 7 Truitt Savell 2021-01-26 14:29:42 PST 
The newly added test imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/zero-or-infinity-001.html

is constantly crashing 

History;
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-sizing%2Faspect-ratio%2Fzero-or-infinity-001.html

Log:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x000000010e9059d3 operator/ + 8 (LayoutUnit.h:513) [inlined]
1   com.apple.WebCore             	0x000000010e9059d3 blockSizeFromAspectRatio + 35 (RenderBox.h:713) [inlined]
2   com.apple.WebCore             	0x000000010e9059d3 WebCore::RenderBox::computeLogicalHeight(WebCore::LayoutUnit, WebCore::LayoutUnit) const + 2691 (RenderBox.cpp:2947)
3   com.apple.WebCore             	0x000000010e904dbc WebCore::RenderBox::updateLogicalHeight() + 140 (RenderBox.cpp:2872)
4   com.apple.WebCore             	0x000000010e8d86f3 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) + 1715 (RenderBlockFlow.cpp:545)
5   com.apple.WebCore             	0x000000010e8c5c2a WebCore::RenderBlock::layout() + 42 (RenderBlock.cpp:598)
Comment 8 Rob Buis 2021-01-26 21:10:54 PST 
I have a fix for the crash here, I will land this later today:
https://bugs.webkit.org/show_bug.cgi?id=220970