| Summary: | Enable webrtc video capture in GPUProcess for iOS WebKitTestRunner | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ap, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 220936, 221035 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2021-01-26 01:17:44 PST
Created attachment 418378 [details]
Patch
Comment on attachment 418378 [details]
Patch
It is hard for me to understand why this does what the ChangeLog says. The patch removes disabling WebRTCPlatformCodecsInGPUProcessEnabled cross-platform, enables CaptureAudioInGPUProcessEnabled on Mac, and CaptureVideoInGPUProcessEnabled cross-platform. More explanation in ChangeLog could be useful.
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 418378 [details] > Patch > > It is hard for me to understand why this does what the ChangeLog says. The > patch removes disabling WebRTCPlatformCodecsInGPUProcessEnabled > cross-platform, enables CaptureAudioInGPUProcessEnabled on Mac, and > CaptureVideoInGPUProcessEnabled cross-platform. More explanation in > ChangeLog could be useful. Bug title is not clear, this is about enabling webrtc capture in GPUProcess in WTR on iOS. Created attachment 418721 [details]
Patch
Following tests are failing: fast/speechrecognition/ios/audio-capture.html fast/speechrecognition/ios/restart-recognition-after-stop.html fast/speechrecognition/ios/start-recognition-then-stop.html platform/ios/mediastream/video-muted-in-background-tab.html First 3 are probably due to speech recognition not working in GPU process. 3rd one is using internals API which is not well supported with GPUProcess. But there is probably a need to better handle the case of visibility interruption on iOS when GPU process is doing the capture. Created attachment 418848 [details]
Patch
Created attachment 418856 [details]
Patch
Committed r272304: <https://trac.webkit.org/changeset/272304> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418856 [details]. |