Bug 220960

Summary: Mute audio capture for speech recognition based on shouldInterruptAudioOnPageVisibilityChange when page is invisible
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: stephan.szabo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Sihui Liu
Reported 2021-01-25 17:18:41 PST
...
Attachments
Patch (8.21 KB, patch)
2021-01-25 17:30 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (7.63 KB, patch)
2021-01-25 17:31 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.58 KB, patch)
2021-01-26 00:18 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (7.67 KB, patch)
2021-01-26 09:45 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (7.99 KB, patch)
2021-01-26 15:24 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.26 KB, patch)
2021-01-26 20:54 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-01-25 17:30:12 PST
Created attachment 418360 [details] Patch
Sihui Liu
Comment 2 2021-01-25 17:31:18 PST
Created attachment 418361 [details] Patch
Stephan Szabo
Comment 3 2021-01-25 18:58:12 PST
Comment on attachment 418361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418361&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:1793 > + if (!RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange()) This seems like it may need to be in at least a #if ENABLE(MEDIA_STREAM) since RealtimeMediaSourceCenter.h uses one around the whole body.
Sihui Liu
Comment 4 2021-01-26 00:18:28 PST
Created attachment 418376 [details] Patch
youenn fablet
Comment 5 2021-01-26 00:35:14 PST
Comment on attachment 418376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418376&action=review > Source/WebKit/UIProcess/SpeechRecognitionPermissionManager.cpp:166 > + m_suspended = true; Do we really need that change? It moves away from being able to apply user gesture constraint to this API, which seems desirable given this asks for microphone and can prompt the user.
Sihui Liu
Comment 6 2021-01-26 09:45:36 PST
Created attachment 418432 [details] Patch
Sihui Liu
Comment 7 2021-01-26 15:24:42 PST
Created attachment 418479 [details] Patch
Sihui Liu
Comment 8 2021-01-26 20:54:18 PST
Created attachment 418502 [details] Patch
EWS
Comment 9 2021-01-26 22:31:11 PST
Committed r271935: <https://trac.webkit.org/changeset/271935> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418502 [details].
Radar WebKit Bug Importer
Comment 10 2021-01-26 22:32:12 PST
<rdar://problem/73648946>
Note You need to log in before you can comment on or make changes to this bug.