| Summary: | Add stub in ContentExtensionsBackend for HTTPS upgrade | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2021-01-25 17:02:56 PST
Created attachment 418358 [details]
Patch
Comment on attachment 418358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review > Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58 > +#import <WebKitAdditions/ContentRuleListAdditions.mm> Implemented in rdar://problem/73625317 Comment on attachment 418358 [details]
Patch
r=me
Committed r272293: <https://trac.webkit.org/changeset/272293> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418358 [details]. Comment on attachment 418358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review >> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58 >> +#import <WebKitAdditions/ContentRuleListAdditions.mm> > > Implemented in rdar://problem/73625317 How is it that we pull a .mm file into a .cpp file? Comment on attachment 418358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review >>> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58 >>> +#import <WebKitAdditions/ContentRuleListAdditions.mm> >> >> Implemented in rdar://problem/73625317 > > How is it that we pull a .mm file into a .cpp file? That's not great. The c preprocessor can pull anything in. This mm file happens to not have any objc so it works. We should rename it. |