Bug 220953

Summary: Changes to commit-log-editor should trigger webkitpy EWS tests
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, darin, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220950
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Ryan Haddad 2021-01-25 15:20:26 PST 
Since checkout_unittest.py includes tests that rely on commit-log-editor, we should ensure that changes to that commit-log-editor trigger webkitpy test runs in EWS.
Comment 1 Radar WebKit Bug Importer 2021-01-25 15:23:54 PST 
<rdar://problem/73590954>
Comment 2 Ryan Haddad 2021-01-25 15:31:13 PST 
Created attachment 418348 [details]
Patch
Comment 3 Aakash Jain 2021-01-25 15:34:26 PST 
Created attachment 418352 [details]
Patch
Comment 4 Darin Adler 2021-01-25 15:38:42 PST 
Comment on attachment 418352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418352&action=review

> Tools/CISupport/ews-build/steps_unittest.py:2423
> +        file_names = ['Tools/Scripts/webkitpy', 'Tools/Scripts/libraries', 'Tools/Script/commit-log-editor']

This won’t work because it says "Script" instead of "Scripts".
Comment 5 Aakash Jain 2021-01-25 15:41:34 PST 
Created attachment 418353 [details]
Patch
Comment 6 Aakash Jain 2021-01-25 15:42:01 PST 
(In reply to Darin Adler from comment #4)
> This won’t work because it says "Script" instead of "Scripts".
Good catch. Fixed in updated patch.
Comment 7 EWS 2021-01-25 16:50:59 PST 
Committed r271869: <https://trac.webkit.org/changeset/271869>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418353 [details].