| Summary: | [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, galpeter, gyuyoung.kim, Hironori.Fujii, ryuan.choi, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2021-01-25 12:26:16 PST
Created attachment 418322 [details]
Patch
Comment on attachment 418322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review > Source/cmake/OptionsWin.cmake:90 > + WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF) Nice. However, this is a breaking change. But, I think no WinCairo users are affected. Comment on attachment 418322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review > Source/WebCore/platform/network/curl/CurlContext.cpp:534 > +#if ENABLE(FTPDIR) All upstream curl ports disable FTDIR now. You can remove this unused code if you want. Committed r272171: <https://trac.webkit.org/changeset/272171> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418322 [details]. |