Bug 220928
| Summary: | 2 WPT tests in css/css-color/predefined-*.html failing (was 14) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | darin, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220247 | ||
| Bug Depends on: | 220940, 221018, 221114, 221116, 221190, 222235 | ||
| Bug Blocks: | |||
Sam Weinig
Many of the WPT tests matching css/css-color/predefined-*.html are failing in WebKit. The complete set that fail are:
imported/w3c/web-platform-tests/css/css-color/predefined-002.html
imported/w3c/web-platform-tests/css/css-color/predefined-003.html
imported/w3c/web-platform-tests/css/css-color/predefined-004.html
imported/w3c/web-platform-tests/css/css-color/predefined-006.html
imported/w3c/web-platform-tests/css/css-color/predefined-007.html
imported/w3c/web-platform-tests/css/css-color/predefined-008.html
imported/w3c/web-platform-tests/css/css-color/predefined-009.html
imported/w3c/web-platform-tests/css/css-color/predefined-010.html
imported/w3c/web-platform-tests/css/css-color/predefined-011.html
imported/w3c/web-platform-tests/css/css-color/predefined-012.html
imported/w3c/web-platform-tests/css/css-color/predefined-014.html
imported/w3c/web-platform-tests/css/css-color/predefined-015.html
imported/w3c/web-platform-tests/css/css-color/predefined-016.html
imported/w3c/web-platform-tests/css/css-color/predefined-017.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
Interested to learn what kind of failures these are. User-visible failures of some kind? Subtle failures where the tests *require* rounding color values to lower precision? Watching this space.
Sam Weinig
Fixing a few in 220940.
Darin Adler
We could have titled this bug "14 tests failing" rather than "many tests failing".
Darin Adler
And after bug 220940, down to 11.
Darin Adler
Could use that style people sometimes use in bugs inside Apple: "11 tests failing (was 14)".
Sam Weinig
And after bug 221018, down to 9.
Sam Weinig
And after bug 221114, down to 7.
Sam Weinig
(In reply to Sam Weinig from comment #7)
> And after bug 221114, down to 7.
Actually, it is down to 8.
Sam Weinig
(When Darin wrote "down to 11", it was actually 12, and I have been miscounting since then :) ).
Sam Weinig
And after bug 221116, down to 6.
Radar WebKit Bug Importer
<rdar://problem/73830969>
Sam Weinig
After bug 221190, down to 5.
Sam Weinig
After bug 222235, down to 2.
Sam Weinig
The final 2 will likely be removed from the test suite as fallback seems likely to be removed from the spec - https://github.com/w3c/csswg-drafts/issues/5931.
Either way, holding off on implementing fallback until that is resolved.
Tim Nguyen (:ntim)
*** This bug has been marked as a duplicate of bug 225438 ***