| Summary: | Upstream to WPT Shadow DOM tests related to :focus pseudo-class | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||||
| Component: | Tools / Tests | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | clopez, ews-watchlist, rniwa, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/27303 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Manuel Rego Casasnovas
2021-01-24 23:12:35 PST
Created attachment 418251 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 418252 [details]
Patch
Created attachment 418255 [details]
Patch
The PR to be reviewed upstream is at: https://github.com/web-platform-tests/wpt/pull/27303 Comment on attachment 418255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418255&action=review > LayoutTests/imported/w3c/ChangeLog:18 > + * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html. Please unskip these tests in iOS. Created attachment 418509 [details]
Patch
Comment on attachment 418255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418255&action=review Thanks for the WPT review. Uploading new version unskipping tests in iOS. >> LayoutTests/imported/w3c/ChangeLog:18 >> + * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html. > > Please unskip these tests in iOS. Done. Let's wait for EWS. Comment on attachment 418509 [details]
Patch
Windows EWS failure is unrelated, so let's land this.
Committed r271944: <https://trac.webkit.org/changeset/271944> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418509 [details]. |