| Summary: | [webkitpy][GTK] Xvfb driver fails to start with python3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||
| Component: | Tools / Tests | Assignee: | Lauro Moura <lmoura> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Oops. There was bug210698 with the same issue. Closing this one. *** This bug has been marked as a duplicate of bug 210698 *** Actually, reopening to track in this one, as the description is more precise. (Sorry for the noise) Created attachment 418177 [details]
Patch
The style checker failed due to set_inheritable missing from the `os` module, but it's guarded by a check for py3. Committed r271764: <https://trac.webkit.org/changeset/271764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418177 [details]. |
Sample command: python3 Tools/Scripts/run-webdriver-tests --verbose --gtk --release --display-server=xvfb Running inside flatpak gives the trace below. Hangs silently running from the desktop at the same point, regardless of inside Flatpak or outside it. Traceback (most recent call last): File "Tools/Scripts/run-webdriver-tests", line 84, in <module> runner = WebDriverTestRunner(port) File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 63, in __init__ env = self._display_driver._setup_environ_for_test() File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 99, in _setup_environ_for_test display_id = self._xvfb_run(port_server_environment) File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 87, in _xvfb_run display_id = self._xvfb_read_display_id(read_fd) File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 63, in _xvfb_read_display_id fd_list = select.select(fd_set, [], [])[0] KeyboardInterrupt