Bug 220856

Summary:	TransformationMatrix::Recompose() and Decompose() incorrectly transpose rotation
Product:	WebKit	Reporter:	Imanol Fernandez <ifernandez>
Component:	Animations	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, dino, graouts, krit, mrobinson, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All

Description Imanol Fernandez 2021-01-22 03:05:45 PST

The computation of quaternions during matrix decomposition looks like it's based off of the matrix transpose. The matrix data is actually column major order but the quaternion operations seem to assume row major order.

More info in the equivalent chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=929841

Comment 1 Radar WebKit Bug Importer 2021-01-29 03:06:11 PST

<rdar://problem/73747851>

Comment 2 Matt Woodrow 2023-08-28 18:03:58 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17162

Comment 3 EWS 2023-08-29 14:45:25 PDT

Committed 267424@main (a959acf1111c): <https://commits.webkit.org/267424@main>

Reviewed commits have been landed. Closing PR #17162 and removing active labels.