Bug 220854

Summary: Remove individual settings accessors from WorkerGlobalScope and add Settings::Values accessor
Product: WebKit Reporter: Chris Lord <clord>
Component: WebCore Misc.Assignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, gyuyoung.kim, kbr, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202793    
Attachments:
Description Flags
Patch
none
Patch none

Chris Lord
Reported 2021-01-22 02:38:08 PST
Currently, some individual settings are accessible via WorkerGlobalScope, but this isn't really a tenable way to do things long-term. I suggest removing these and just making the Settings::Values accessible. This is useful for OffscreenCanvas which requires a bunch of font-related settings that would be tedious to write a bunch of new accessors for.
Attachments
Patch (4.57 KB, patch)
2021-01-22 02:42 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2021-01-22 03:26 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2021-01-22 02:42:04 PST
Created attachment 418127 [details] Patch
Chris Lord
Comment 2 2021-01-22 03:26:37 PST
Created attachment 418132 [details] Patch
EWS
Comment 3 2021-01-22 04:11:43 PST
Committed r271743: <https://trac.webkit.org/changeset/271743> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418132 [details].
Radar WebKit Bug Importer
Comment 4 2021-01-22 04:12:14 PST
<rdar://problem/73493954>
Note You need to log in before you can comment on or make changes to this bug.