| Summary: | WebGL powerPreference is not tested | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
| Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, ap, dino, kbr, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 220843 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Kimmo Kinnunen
2021-01-22 00:16:23 PST
Created attachment 418113 [details]
Patch
Comment on attachment 418113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418113&action=review Looks good to me. r+ > LayoutTests/fast/canvas/webgl/high-performance-context.html:14 > +description("Tests that a high-performance contexts do not fail."); "contexts do not" -> "context does not" > LayoutTests/fast/canvas/webgl/high-performance-context.html:19 > +var wtu = WebGLTestUtils; Nowadays, prefer "let" (or "const") over "var". In case they're useful, here are some related tests run against Chromium: https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/gpu_process_integration_test.py;l=112?q=gpu_process_integration_test https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/pixel_test_pages.py;l=642 the latter of which reference helper functions in this file: https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/pixel_integration_test.py;l=221 Looks like this r+ patch didn't landed and I checked via BugID on Webkit GitHub. Just wanted to update. Thanks! |