Bug 220812

Summary: REGRESSION (r271691): [BigSur] 22 API tests failing with Unknown C++ exception thrown in the test body
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220633
Attachments:
Description Flags
Revert r271691 none

Description Ryan Haddad 2021-01-21 12:02:48 PST 
There are 22 API tests failing (only) on Big Sur bots with the following output:

File name unavailable
Unknown C++ exception thrown in the test body.

This appears to have started with https://trac.webkit.org/changeset/271691

Here are the affected tests:
    TestWebKitAPI.CloseWebViewDuringEnterFullscreen.VideoFullscreen
    TestWebKitAPI.WKWebViewCloseAllMediaPresentations.ElementFullscreen
    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.ScrollWithTitlebarAdjacency
    TestWebKitAPI.CloseWebViewAfterEnterFullscreen.VideoFullscreen
    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.ChangeViewVisibility
    TestWebKitAPI.TopContentInset.AutomaticAdjustment
    TestWebKitAPI.TopContentInset.AutomaticAdjustmentDisabled
    TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen
    TestWebKitAPI.TopContentInset.Fullscreen
    TestWebKitAPI.WKWebViewCloseAllMediaPresentations.VideoFullscreen
    TestWebKitAPI.Fullscreen.Focus
    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.BackForwardCache
    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.ScrollWithoutTitlebarAdjacency
    TestWebKitAPI.CloseWebViewAfterEnterFullscreen.ElementFullscreen
    TestWebKitAPI.WKWebView.PrepareForMoveToWindowThenWindowDeallocBeforeMoving
    TestWebKitAPI.Fullscreen.WKViewDelegate
    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.ChangeTitlebarAdjacency
    TestWebKitAPI.Fullscreen.Delegate
    TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen
    TestWebKitAPI.Fullscreen.PointerLeave
    TestWebKitAPI.CloseWebViewDuringEnterFullscreen.ElementFullscreen
    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.NavigationResetsTitlebarAppearance

https://build.webkit.org/builders/Apple-BigSur-Release-WK2-Tests/builds/1077/steps/run-api-tests/logs/stdio
Comment 1 Radar WebKit Bug Importer 2021-01-21 12:02:57 PST 
<rdar://problem/73462770>
Comment 2 Ryan Haddad 2021-01-21 12:03:58 PST 
I checked two of the bots and didn't find any related crash logs.
Comment 3 Ryan Haddad 2021-01-21 13:29:55 PST 
This is reproducible for me by running a single test:
$ run-api-tests TestWebKitAPI.WKWebViewTitlebarSeparatorTests.BackForwardCache
Running tests
    LEAK: 1 WebProcessPool
    LEAK: 1 WebPageProxy

    File name unavailable
    Unknown C++ exception thrown in the test body.

TestWebKitAPI.WKWebViewTitlebarSeparatorTests.BackForwardCache Failed
Ran 1 tests of 1 with 0 successful
------------------------------
Test suite failed

Failed

    TestWebKitAPI.WKWebViewTitlebarSeparatorTests.BackForwardCache
        LEAK: 1 WebProcessPool
        LEAK: 1 WebPageProxy

        File name unavailable
        Unknown C++ exception thrown in the test body.
Comment 4 Aditya Keerthi 2021-01-21 13:54:49 PST 
Created attachment 418083 [details]
Revert r271691
Comment 5 Aditya Keerthi 2021-01-21 13:59:44 PST 
Reverting, while I investigate the underlying cause.
Comment 6 EWS 2021-01-21 14:55:04 PST 
Committed r271713: <https://trac.webkit.org/changeset/271713>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418083 [details].