| Summary: | Add WebXR to features.json | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, joepeck, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-01-21 11:20:05 PST
Created attachment 418065 [details]
Patch
Comment on attachment 418065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review > Source/WebCore/features.json:822 > + "enabled-by-default": true Let's remove this. > Source/WebCore/features.json:826 > + "keywords": ["webxr", "webgl", "webgpu"], are webgl and webgpu relevant? Comment on attachment 418065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review >> Source/WebCore/features.json:826 >> + "keywords": ["webxr", "webgl", "webgpu"], > > are webgl and webgpu relevant? yes! XR without webgl/webgpu is hardly an XR at all! Created attachment 418066 [details]
Patch for committing
Comment on attachment 418065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review >> Source/WebCore/features.json:822 >> + "enabled-by-default": true > > Let's remove this. it's definitely not on by default Committed r271721: <https://trac.webkit.org/changeset/271721> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418066 [details]. |