| Summary: | [webkitcorepy] Don't import six at the top level | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Angelos Oikonomopoulos
2021-01-21 07:06:10 PST
Created attachment 418037 [details]
Patch
Comment on attachment 418037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338 > + from six import reraise Do we need to import it again whiling exiting? Comment on attachment 418037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review >> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338 >> + from six import reraise > > Do we need to import it again whiling exiting? We do, because we use it on line 352 Committed r271692: <https://trac.webkit.org/changeset/271692> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418037 [details]. *** Bug 220791 has been marked as a duplicate of this bug. *** |