| Summary: | [webkitcorepy] Use AutoInstall for webkitcorepy deps as well | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | aakash_jain, clopez, ews-watchlist, glenn, jbedard | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220791 | ||||||
| Attachments: |
|
||||||
|
Description
Angelos Oikonomopoulos
2021-01-21 05:38:03 PST
Created attachment 418033 [details]
Patch
Comment on attachment 418033 [details]
Patch
In most places, this would be the right approach, but webkitcorepy is a special case because it’s imported before the autoinstaller is configured (and not just in webkitpy, that’s also true in some Apple non-public code)
What I should have done is put the six import in task_pool inside the function (or functions) that are actually using it. If no one else posts a patch, I’ll get to it in the next hour or two.
(In reply to Jonathan Bedard from comment #2) > Comment on attachment 418033 [details] > Patch > > In most places, this would be the right approach, but webkitcorepy is a > special case because it’s imported before the autoinstaller is configured > (and not just in webkitpy, that’s also true in some Apple non-public code) Ah, so you need the autoinstaller configuration to be in the consumers of webkitcorepy? That makes sense. > What I should have done is put the six import in task_pool inside the > function (or functions) that are actually using it. If no one else posts a > patch, I’ll get to it in the next hour or two. Sure, I'll file a new bug. Angelos fixed this in the other bug he linked, closing this one. |