| Summary: | Forbid '|' in URL hosts | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, clopez, cmarcelo, ews-watchlist, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2021-01-20 12:50:49 PST
Created attachment 417990 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 417991 [details]
Patch
Created attachment 418006 [details]
Patch
Comment on attachment 418006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418006&action=review > LayoutTests/fast/url/file-http-base-expected.txt:13 > +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar. Should we update this test? Comment on attachment 418006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418006&action=review >> LayoutTests/fast/url/file-http-base-expected.txt:13 >> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar. > > Should we update this test? I don't think so. It failed before and after, and most of the tests in this file fail. commit-queue failed to commit attachment 418006 [details] to WebKit repository.
(In reply to Alex Christensen from comment #6) > Comment on attachment 418006 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418006&action=review > > >> LayoutTests/fast/url/file-http-base-expected.txt:13 > >> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar. > > > > Should we update this test? > > I don't think so. It failed before and after, and most of the tests in this > file fail. So we should probably update the test so as to PASS (or remove the test). Created attachment 418443 [details]
Patch
Committed r271899: <https://trac.webkit.org/changeset/271899> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418443 [details]. |