| Summary: | EWS should display commit identifier in builds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220479 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2021-01-20 09:13:41 PST
Created attachment 417995 [details]
Patch
Sample runs: Builder queue: https://ews-build.webkit-uat.org/#/builders/35/builds/84512 Tester queue: https://ews-build.webkit-uat.org/#/builders/34/builds/21300 Comment on attachment 417995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417995&action=review > Tools/CISupport/ews-build/steps.py:179 > + revision = self.getProperty('ews_revision', self.getProperty('got_revision')) This is actually the commit hash, right? > Tools/CISupport/ews-build/steps.py:182 > + self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision]) Should we consider invoking this with python3? (In reply to Jonathan Bedard from comment #3) > This is actually the commit hash, right? Yes > Should we consider invoking this with python3? I am not sure if all the bots (including external bots) having python 3. Might be a good idea to verify that and do it in separate patch. Committed r271675: <https://trac.webkit.org/changeset/271675> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417995 [details]. |