Bug 220762

Summary: BuildbotTriggerable should not update build requests from another triggerable.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description dewei_zhu 2021-01-19 22:38:28 PST 
BuildbotTriggerable should not update build requests from another triggerable.
Comment 1 dewei_zhu 2021-01-19 23:10:41 PST 
Created attachment 417943 [details]
Patch
Comment 2 dewei_zhu 2021-01-19 23:13:30 PST 
rdar://73166544
rdar://72347539
Comment 3 Ryosuke Niwa 2021-01-19 23:20:57 PST 
Comment on attachment 417943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417943&action=review

> Websites/perf.webkit.org/public/api/build-requests.php:53
> +        $update_fields = array();

This should be either fields_to_update or updated_fields.
Comment 4 dewei_zhu 2021-01-19 23:33:34 PST 
Created attachment 417945 [details]
Patch
Comment 5 dewei_zhu 2021-01-19 23:39:45 PST 
Created attachment 417946 [details]
Patch for landing
Comment 6 EWS 2021-01-20 00:32:01 PST 
Committed r271639: <https://trac.webkit.org/changeset/271639>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417946 [details].